Go to file
David Mirabito via Linuxptp-devel 6b61ba29c7 Avoid fault when receiving zero length packets
The manpage for recvmsg says -1 will be returned on error, Zero indicates an
"orderly shutdown", presumably only in case of stream sockets.
Further, UNIX Network Programming, Vol 1 says ".. a return value of 0 from
recvfrom is acceptable for a datagram protocol"

Such packets have been observed in the wild, aimed at PTP's multicast
address and port, possibly related to malformed management queries.

Patch to properly check return from recvmesg and not trigger the fault
codepath. Instead, such packets are treated as "Bad Message" the same as
non-zero but still too-short UDP payloads.

Signed-off-by: David Mirabito <davidjm@arista.com>
2019-03-25 06:25:07 -07:00
configs Add example configuration for Automotive Profile. 2018-10-04 19:38:19 -07:00
.gitignore snmp4lptp: Add snmp sub agent for linuxptp 2018-09-07 09:44:52 -07:00
CODING_STYLE.org
COPYING
README.org Simplify the systems requirements section of the readme file. 2019-02-24 19:26:36 -08:00
address.h ptp4l: Add IPoIB interface support for ptp4l 2017-08-10 10:42:16 +02:00
as_capable.h port: Add configurable option to set asCapable. 2018-10-04 19:38:19 -07:00
bmc.c Add BMCA config option. 2018-10-04 19:38:19 -07:00
bmc.h telecom: Add a configuration option to use the alternate BMCA. 2018-04-24 21:50:03 -07:00
clock.c Fix building with new kernel headers. 2019-01-06 19:56:25 -08:00
clock.h Introduce the maxStepsRemoved attribute 2018-09-30 18:39:39 -07:00
clockadj.c Added support for opening POSIX clock devices 2019-01-06 19:41:45 -08:00
clockadj.h Added support for opening POSIX clock devices 2019-01-06 19:41:45 -08:00
clockcheck.c
clockcheck.h
config.c Add ignore_source_id config option. 2018-10-04 19:38:19 -07:00
config.h config: Introduce a unicast master table. 2018-07-01 06:27:48 -07:00
contain.h Fix a trivial spelling mistake in a comment. 2014-06-02 18:00:21 +02:00
ddt.h
designated_fsm.c Add BMCA config option. 2018-10-04 19:38:19 -07:00
designated_fsm.h Include missing headers. 2018-11-01 20:17:50 -07:00
dm.h
ds.h telecom: Introduce the local priority attribute into the data set. 2018-04-24 21:39:13 -07:00
e2e_tc.c fd: Introduce a unicast service timer. 2018-07-01 22:10:06 -07:00
ether.h ptp4l: Add IPoIB interface support for ptp4l 2017-08-10 10:42:16 +02:00
fault.c port: allow running a boundary clock with multiple clock devices. 2014-12-18 11:38:00 +01:00
fault.h fault: protect header against multiple inclusion. 2016-04-03 14:45:41 +02:00
fd.h fd: Introduce a unicast service timer. 2018-07-01 22:10:06 -07:00
filter.c Add median filter. 2013-10-30 21:54:07 +01:00
filter.h Add median filter. 2013-10-30 21:54:07 +01:00
filter_private.h
foreign.h
fsm.c fsm: Make the transition out of INITIALIZING part of the FSM code. 2017-01-08 21:34:54 +01:00
fsm.h Add BMCA config option. 2018-10-04 19:38:19 -07:00
hash.c Introduce a simple hash table implementation. 2015-08-16 11:20:23 +02:00
hash.h Introduce a simple hash table implementation. 2015-08-16 11:20:23 +02:00
hwstamp_ctl.8 Bump the date on the hwstamp_ctl man page. 2014-06-04 15:17:22 +02:00
hwstamp_ctl.c Fix copying of device name to ifreq. 2014-09-21 13:10:27 +02:00
incdefs.sh Introduce peer to peer one step. 2018-03-27 22:26:32 -07:00
linreg.c linreg: use sample weight. 2015-03-27 10:58:04 +01:00
linreg.h Add an adaptive servo based on linear regression. 2014-03-14 09:52:40 +01:00
makefile Add BMCA config option. 2018-10-04 19:38:19 -07:00
mave.c tmv: Add missing uses of tmv_zero() 2018-03-07 07:55:51 -08:00
mave.h
missing.h Introduce unicast service. 2018-07-01 22:10:07 -07:00
mmedian.c tmv: Generalise tmv_eq() to tmv_cmp() 2018-03-07 07:55:51 -08:00
mmedian.h Add median filter. 2013-10-30 21:54:07 +01:00
msg.c msg: inline net2host64() and host2net64() 2018-07-21 16:28:07 -07:00
msg.h msg: Added const flag in msg_type 2019-01-06 19:47:51 -08:00
mtab.h Introduce the unicast client finite state machine. 2018-07-01 06:27:48 -07:00
notification.h Event notification: port state 2014-05-06 20:08:59 +02:00
nsm.c util: Make a useful helper function more public. 2018-07-01 06:27:47 -07:00
ntpshm.c config: convert 'ntpshm_segment' to the new scheme. 2015-08-23 21:09:45 +02:00
ntpshm.h config: convert 'ntpshm_segment' to the new scheme. 2015-08-23 21:09:45 +02:00
nullf.c Use llabs() instead of fabs() for integers. 2018-11-01 20:17:50 -07:00
nullf.h Add a servo that inhibits all frequency adjustment 2015-07-24 22:17:09 +02:00
p2p_tc.c fd: Introduce a unicast service timer. 2018-07-01 22:10:06 -07:00
pdt.h pdt: Added check if already defined 2018-07-05 23:54:26 -07:00
phc.c Added support for opening POSIX clock devices 2019-01-06 19:41:45 -08:00
phc.h Added support for opening POSIX clock devices 2019-01-06 19:41:45 -08:00
phc2sys.8 phc2sys: fix manpage documentation for -F 2018-05-15 06:14:19 -07:00
phc2sys.c phc2sys: Fix crash when trying to synchronize unadjustable clock. 2019-01-06 20:50:40 -08:00
phc_ctl.8 linuxptp: add phc_ctl program to help debug PHC devices 2014-07-19 07:15:24 +02:00
phc_ctl.c sysoff: Extend API for different sysoff methods. 2019-01-06 20:50:40 -08:00
pi.c Use llabs() instead of fabs() for integers. 2018-11-01 20:17:50 -07:00
pi.h config: convert 'pi_integral_norm_max' to the new scheme. 2015-08-23 21:09:45 +02:00
pmc.8 pmc: Documentation for long opts / cfg file 2018-03-24 21:15:17 -07:00
pmc.c msg: Drop msg->tlv_count. 2018-07-21 16:28:07 -07:00
pmc_common.c pmc_common: Recycle message if allocation of tlv_extra failed 2018-07-19 10:31:06 -07:00
pmc_common.h pmc: Move new common funtionality into pmc_common 2018-07-05 23:17:32 -07:00
port.c Avoid fault when receiving zero length packets 2019-03-25 06:25:07 -07:00
port.h Add BMCA config option. 2018-10-04 19:38:19 -07:00
port_private.h Add ignore_source_id config option. 2018-10-04 19:38:19 -07:00
port_signaling.c port: Hook into the unicast service logic. 2018-07-01 22:10:07 -07:00
pqueue.c Introduce a priority queue implementation. 2018-07-01 22:10:06 -07:00
pqueue.h Introduce a priority queue implementation. 2018-07-01 22:10:06 -07:00
print.c Add options to tag ptp4l and phc2sys log messages. 2017-02-05 16:44:48 +01:00
print.h Add options to tag ptp4l and phc2sys log messages. 2017-02-05 16:44:48 +01:00
ptp4l.8 Add ignore_source_id config option. 2018-10-04 19:38:19 -07:00
ptp4l.c ptp4l: Remove bogus command line option. 2019-03-25 06:04:40 -07:00
raw.c transport: Introduce transmit time stamp deferral. 2018-04-13 22:29:05 -07:00
raw.h config: convert 'p2p_dst_mac', letting it be a per-port option. 2015-08-23 21:09:46 +02:00
rtnl.c rtnl: remove dependency on config.h. 2018-04-19 07:41:11 -07:00
rtnl.h rtnl: remove dependency on config.h. 2018-04-19 07:41:11 -07:00
servo.c servo: NULL pointer check for servo constructors 2017-04-06 06:25:34 +02:00
servo.h config: convert the 'max_frequency' option to the new scheme. 2015-08-23 21:09:45 +02:00
servo_private.h Include missing headers. 2018-11-01 20:17:50 -07:00
sk.c Avoid fault when receiving zero length packets 2019-03-25 06:25:07 -07:00
sk.h sk: Added address family as inargument in sk_set_priority 2018-11-01 20:17:50 -07:00
snmp4lptp.8 snmp4lptp: added snmp4lptp.8 2018-09-30 18:52:56 -07:00
snmp4lptp.c snmp4lptp: Added function for data collection from ptp4l program. 2018-09-07 09:45:40 -07:00
snmp4lptp_mib.h snmp4lptp: Added function for data collection from ptp4l program. 2018-09-07 09:45:40 -07:00
snmpflg.sh snmp4lptp: Add snmp sub agent for linuxptp 2018-09-07 09:44:52 -07:00
stats.c
stats.h
sysoff.c sysoff: Add support for PTP_SYS_OFFSET_EXTENDED ioctl. 2019-01-06 20:50:40 -08:00
sysoff.h sysoff: Add support for PTP_SYS_OFFSET_EXTENDED ioctl. 2019-01-06 20:50:40 -08:00
tc.c transport_txts(): transport argument is unused 2018-06-25 07:24:17 -07:00
tc.h tc: Add the transparent clock implementation. 2018-05-01 07:46:43 -07:00
telecom.c telecom: Add the data set comparison algorithm from the Telecom Profiles. 2018-04-24 21:39:13 -07:00
timemaster.8 timemaster: Allow ptp4l-specific sections in [ptp4l.conf]. 2018-09-30 18:54:31 -07:00
timemaster.c Fix building with new kernel headers. 2019-01-06 19:56:25 -08:00
tlv.c msg: Support unicast negotiation message formats. 2018-07-01 06:27:48 -07:00
tlv.h msg: Support unicast negotiation message formats. 2018-07-01 06:27:48 -07:00
tmv.h tmv: Avoid overflow when byte shift in tmv_to_TimeInterval 2019-01-06 20:09:39 -08:00
transport.c transport_txts(): transport argument is unused 2018-06-25 07:24:17 -07:00
transport.h transport_txts(): transport argument is unused 2018-06-25 07:24:17 -07:00
transport_private.h transport: Use the proper enumerated event code. 2018-04-13 22:27:03 -07:00
tsproc.c tmv: Add tmv_sign() 2018-03-07 07:55:51 -08:00
tsproc.h tsproc: add raw and weighting modes. 2015-03-27 10:58:04 +01:00
udp.c sk: Added address family as inargument in sk_set_priority 2018-11-01 20:17:50 -07:00
udp.h
udp6.c sk: Added address family as inargument in sk_set_priority 2018-11-01 20:17:50 -07:00
udp6.h config: convert 'udp6_scope' to the new scheme. 2015-08-23 21:09:45 +02:00
uds.c transport: Use the proper enumerated event code. 2018-04-13 22:27:03 -07:00
uds.h config: convert 'uds_address' to the new scheme. 2015-08-23 21:09:46 +02:00
unicast_client.c Introduce unicast client logic. 2018-07-01 22:10:06 -07:00
unicast_client.h Introduce unicast client logic. 2018-07-01 22:10:06 -07:00
unicast_fsm.c Introduce the unicast client finite state machine. 2018-07-01 06:27:48 -07:00
unicast_fsm.h Introduce the unicast client finite state machine. 2018-07-01 06:27:48 -07:00
unicast_service.c unicast: Process timeouts equal to current time. 2018-09-30 18:54:31 -07:00
unicast_service.h Introduce unicast service. 2018-07-01 22:10:07 -07:00
util.c util: Added IPv6 support in help funtions addreq and str2addr 2018-11-01 20:17:50 -07:00
util.h Add possibility to set clockIdentity 2018-09-30 18:45:52 -07:00
version.c
version.h
version.sh Version 2.0 2018-08-12 14:08:43 -07:00

README.org

Introduction

This software is an implementation of the Precision Time Protocol (PTP) according to IEEE standard 1588 for Linux. The dual design goals are to provide a robust implementation of the standard and to use the most relevant and modern Application Programming Interfaces (API) offered by the Linux kernel. Supporting legacy APIs and other platforms is not a goal.

License

The software is copyrighted by the authors and is licensed under the GNU General Public License. See the file, COPYING, for details of the license terms.

Features

  • Supports hardware and software time stamping via the Linux SO_TIMESTAMPING socket option.
  • Supports the Linux PTP Hardware Clock (PHC) subsystem by using the clock_gettime family of calls, including the clock_adjtimex system call.
  • Implements Boundary Clock (BC), Ordinary Clock (OC) and Transparent Clock (TC).
  • Transport over UDP/IPv4, UDP/IPv6, and raw Ethernet (Layer 2).
  • Supports IEEE 802.1AS-2011 in the role of end station.
  • Modular design allowing painless addition of new transports and clock servos.
  • Implements unicast operation.
  • Supports a number of profiles, including:

    • The automotive profile
    • The default 1588 profile.
    • The enterprise profile.
    • The telecom profiles G.8265.1, G.8275.1, and G.8275.2.
  • Supports the NetSync Monitor protocol.
  • Implements Peer to peer one-step.
  • Supports bonded, IPoIB, and vlan interfaces.

Getting the Code

You can download the latest released version at Source Forge.

http://sourceforge.net/projects/linuxptp/files/latest/download

The source code is managed using the git version control system. To get your own copy of the project sources, use the following command.

  git clone git://git.code.sf.net/p/linuxptp/code linuxptp

If the git protocol is blocked by your local area network, then you can use the alternative HTTP protocol instead.

  git clone http://git.code.sf.net/p/linuxptp/code linuxptp

System Requirements

In order to run this software, you need Linux kernel version 3.0 or newer. Check whether your network interface supports PTP with the following command.

  ethtool -T eth0

This command shows whether a MAC supports hardware or software time stamping. The following example output indicates support for hardware time stamping.

Time stamping parameters for eth6:
Capabilities:
        hardware-transmit     (SOF_TIMESTAMPING_TX_HARDWARE)
        software-transmit     (SOF_TIMESTAMPING_TX_SOFTWARE)
        hardware-receive      (SOF_TIMESTAMPING_RX_HARDWARE)
        software-receive      (SOF_TIMESTAMPING_RX_SOFTWARE)
        software-system-clock (SOF_TIMESTAMPING_SOFTWARE)
        hardware-raw-clock    (SOF_TIMESTAMPING_RAW_HARDWARE)
PTP Hardware Clock: 1
Hardware Transmit Timestamp Modes:
        off                   (HWTSTAMP_TX_OFF)
        on                    (HWTSTAMP_TX_ON)
Hardware Receive Filter Modes:
        none                  (HWTSTAMP_FILTER_NONE)
        all                   (HWTSTAMP_FILTER_ALL)

The next example shows the case where the MAC only supports software time stamping. The ptp4l program requires either the -S command line argument or the time_stamping software configuration option when using such interfaces.

Time stamping parameters for enp6s0:
Capabilities:
        software-transmit     (SOF_TIMESTAMPING_TX_SOFTWARE)
        software-receive      (SOF_TIMESTAMPING_RX_SOFTWARE)
        software-system-clock (SOF_TIMESTAMPING_SOFTWARE)
PTP Hardware Clock: none
Hardware Transmit Timestamp Modes: none
Hardware Receive Filter Modes: none

Note the software-transmit (SOF_TIMESTAMPING_TX_SOFTWARE) capability. If this is lacking, then the MAC cannot be used at all. However, adding this capability entails adding a single line of code to the device driver.

Installation

  1. Just type 'make'
  2. If you compiled your own kernel (and the headers are not installed into the system path), then you should set the KBUILD_OUTPUT environment variable as in the example, above.
  3. In order to install the programs and man pages into /usr/local, run the 'make install' target. You can change the installation directories by setttings the variables prefix, sbindir, mandir, and man8dir on the make command line.

Getting Involved

The software development is hosted at Source Forge.

https://sourceforge.net/projects/linuxptp/

Reporting Bugs

Please report any bugs or other issues with the software to the linuxptp-users mailing list.

https://lists.sourceforge.net/lists/listinfo/linuxptp-users

Development

If you would like to get involved in improving the software, please join the linuxptp-devel mailing list.

https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Submitting Patches

  1. Before submitting patches, please make sure that you are starting your work on the current HEAD of the git repository.
  2. Please checkout the CODING_STYLE.org file for guidelines on how to properly format your code.
  3. Describe your changes. Each patch will be reviewed, and the reviewers need to understand why you did what you did.
  4. Sign-Off each commit, so the changes can be properly attributed to you and you explicitely give your agreement for distribution under linuxptp's license. Signing-off is as simple as:

    git commit -s
    

    or by adding the following line (replace your real name and email) to your patch:

    Signed-off-by: Random J Developer <random@developer.example.org>
    
  5. Finally, send your patches via email to the linuxptp-devel mailing list, where they will be reviewed, and eventually be included in the official code base.

    git send-email --to linuxptp-devel@lists.sourceforge.net origin/master
    

Thanks

Thanks to AudioScience Inc for sponsoring the 8021.AS support.

Thanks to Exablaze for donating an ExaNIC X10

Thanks to Intel Corporation for donating four NICs, the 82574, 82580, 82599, and the i210.

Thanks to Meinberg Funkuhren for donating a LANTIME M1000.

Thanks to Moser Baer for sponsoring the Telecom Profiles and unicast support.

For testing I use an OTMC 100 grandmaster clock donated by OMICRON Lab.