From 1de59d62266a5770a3789faece251eda46a495ff Mon Sep 17 00:00:00 2001 From: Richard Cochran Date: Sun, 16 Oct 2016 12:14:08 +0200 Subject: [PATCH] clock: Remove cruft from the creation method. The time stamping setup code needlessly queries the configuration data base over and over, rather than simply using the local variable already assigned. This patch replaces the extraneous config_get_int() calls with the local variable. Signed-off-by: Richard Cochran --- clock.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/clock.c b/clock.c index 55f3c52..8ca749e 100644 --- a/clock.c +++ b/clock.c @@ -891,7 +891,7 @@ struct clock *clock_create(enum clock_type type, struct config *config, } if (!(c->dds.flags & DDS_TWO_STEP_FLAG)) { - switch (config_get_int(config, NULL, "time_stamping")) { + switch (timestamping) { case TS_SOFTWARE: case TS_LEGACY_HW: pr_err("one step is only possible " @@ -908,7 +908,7 @@ struct clock *clock_create(enum clock_type type, struct config *config, } /* Check the time stamping mode on each interface. */ - switch (config_get_int(config, NULL, "time_stamping")) { + switch (timestamping) { case TS_SOFTWARE: required_modes |= SOF_TIMESTAMPING_TX_SOFTWARE | SOF_TIMESTAMPING_RX_SOFTWARE | @@ -940,8 +940,7 @@ struct clock *clock_create(enum clock_type type, struct config *config, /* determine PHC Clock index */ if (config_get_int(config, NULL, "free_running")) { phc_index = -1; - } else if (config_get_int(config, NULL, "time_stamping") == TS_SOFTWARE || - config_get_int(config, NULL, "time_stamping") == TS_LEGACY_HW) { + } else if (timestamping == TS_SOFTWARE || timestamping == TS_LEGACY_HW) { phc_index = -1; } else if (phc_device) { if (1 != sscanf(phc_device, "/dev/ptp%d", &phc_index)) {